Skip to content

BUG: Issue #29128 Series.var not returning the correct result #29353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Nov 19, 2019
Merged

BUG: Issue #29128 Series.var not returning the correct result #29353

merged 20 commits into from
Nov 19, 2019

Conversation

HubertKl
Copy link
Contributor

@HubertKl HubertKl commented Nov 2, 2019

This PR closes #29128

@pep8speaks
Copy link

pep8speaks commented Nov 2, 2019 •
edited
Loading

Hello @HubertKl! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2019-11-09 00:01:11 UTC

jreback
jreback requested changes Nov 2, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a ton of unrelated changes here. can you just change what is releavnt

@HubertKl
Copy link
Contributor Author

HubertKl commented Nov 2, 2019

Sorry for the mess, I ran the wrong version of black.

I updated my PR accordingly to the change requested.

jreback
jreback requested changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, some comments, ping on green.

@jreback jreback added Bug Numeric Operations Arithmetic, Comparison, and Logical operations labels Nov 4, 2019
HubertKl
HubertKl commented Nov 5, 2019
View reviewed changes
Copy link
Contributor Author

@HubertKl HubertKl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes has been done, checks are green. @jreback

@jbrockmendel
Copy link
Member

@HubertKl can you rebase

@HubertKl
Copy link
Contributor Author

HubertKl commented Nov 9, 2019

@HubertKl can you rebase

Done

WillAyd
WillAyd approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@WillAyd WillAyd added this to the 1.0 milestone Nov 19, 2019
@WillAyd WillAyd merged commit 0485115 into pandas-dev:master Nov 19, 2019
@WillAyd
Copy link
Member

WillAyd commented Nov 19, 2019

Thanks @HubertKl

proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@HubertKl @proost
BUG: Issue pandas-dev#29128 Series.var not returning the correct resu…
07a5d4c 
…lt (pandas-dev#29353)
proost pushed a commit to proost/pandas that referenced this pull request Dec 19, 2019
@HubertKl @proost
BUG: Issue pandas-dev#29128 Series.var not returning the correct resu…
0b688c0 
…lt (pandas-dev#29353)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Bug Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Variance of nullable Int64 ignores ddof argument
5 participants
@HubertKl @pep8speaks @jbrockmendel @WillAyd @jreback