Skip to content

BUG: pickle files left behind by tm.round_trip_pickle #30906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2020

Conversation

jbrockmendel
Copy link
Member

No description provided.

Copy link
Member

@jschendel jschendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense. nice find

@WillAyd WillAyd added Clean Testing pandas testing functions or related to the test suite labels Jan 11, 2020
@jreback jreback added this to the 1.0.0 milestone Jan 11, 2020
@jreback
Copy link
Contributor

jreback commented Jan 11, 2020

worth backporting

merge on green

@jbrockmendel
Copy link
Member Author

green

@simonjayhawkins
Copy link
Member

Thanks @jbrockmendel Is it worth moving check_for_file_leaks into a higher level conftest?

gfyoung pushed a commit that referenced this pull request Jan 11, 2020
…ckle (#30913)

Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
@jbrockmendel jbrockmendel deleted the bug-pickle branch January 11, 2020 15:29
@jbrockmendel
Copy link
Member Author

Is it worth moving check_for_file_leaks into a higher level conftest?

Different kind of file leak

jbrockmendel added a commit to jbrockmendel/pandas that referenced this pull request Jan 11, 2020
keechongtan added a commit to keechongtan/pandas that referenced this pull request Jan 13, 2020
…ndexing-1row-df

* upstream/master: (284 commits)
  CLN: leftover ix checks (pandas-dev#30951)
  CI: numpydev changed double to single quote (pandas-dev#30952)
  DOC: Fix whatsnew contributors section (pandas-dev#30926)
  STY: wrong placed space in strings (pandas-dev#30940)
  TYP: type up parts of series.py (pandas-dev#30761)
  DOC: Fix SS03 docstring error (pandas-dev#30939)
  CLN: remove unnecesary _date_check_type (pandas-dev#30932)
  DOC: Fixture docs in pandas/conftest.py (pandas-dev#30917)
  CLN: F-strings (pandas-dev#30916)
  replace syntax with f-string (pandas-dev#30919)
  BUG: pickle files left behind by tm.round_trip_pickle (pandas-dev#30906)
  TYP: offsets (pandas-dev#30897)
  TYP: typing annotations (pandas-dev#30901)
  WEB: Remove from roadmap moving the docstring script (pandas-dev#30893)
  WEB: Removing Discourse links (pandas-dev#30890)
  DOC: Encourage use of pre-commit in the docs (pandas-dev#30864)
  DEPR: fix missing stacklevel in pandas.core.index deprecation (pandas-dev#30878)
  CLN: remove unnecessary overriding in subclasses (pandas-dev#30875)
  RLS: 1.0.0rc0
  BUG: validate Index data is 1D + deprecate multi-dim indexing (pandas-dev#30588)
  ...

# Conflicts:
#	doc/source/whatsnew/v1.0.0.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clean Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants