BUG: missing nose import for skip test #8867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -259,6 +259,7 @@ def test_repr_non_interactive(self): | |||
| def test_repr_max_columns_max_rows(self): | |||
| term_width, term_height = get_terminal_size() | |||
| if term_width < 10 or term_height < 10: | |||
| import nose | |||
There was a problem hiding this comment.
can u put it at the top of the file? thxs
nose.SkipTest used but nose not imported. Import nose at top level and use that throughout.
matthew-brett
force-pushed
the
missing-nose-import
branch
from
eda5aee to
4c5ac16
Compare
jreback
added a commit
that referenced
this pull request
Nov 21, 2014
BUG: missing nose import for skip test
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nose.SkipTest used but nose not imported.