-
Notifications
You must be signed in to change notification settings - Fork 352
Trailing comma can mess up subsequent indentation #491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
The most recent commit which doesn't exhibit this bug happens to be exactly v1.0.0 (d7f4728). |
dev branch! |
I'm not sure what you meant by that comment - was I right to file an issue against the develop branch? |
I thought it was fixed already, this is still a problem but i'll try and fix it for the next push to master. |
bounceme
added a commit
that referenced
this issue
Jun 18, 2016
seems to fix #491, may be necessary to look for a more complex solution if this causes regressions
bounceme
added a commit
that referenced
this issue
Jun 18, 2016
seems to fix #491, may be necessary to look for a more complex solution if this causes regressions
Has this issue been fixed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I haven't really characterised this fully, but it seems that a trailing comma in an array literal can mess up subsequent block indentation. Using the latest commit on develop (ea58033), it indents the following code like so:
If you remove the trailing comma, you get this:
which is how I'd expect the code to indented.
The text was updated successfully, but these errors were encountered: