Skip to content

New alignment procedure #1308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2025
Merged

New alignment procedure #1308

merged 1 commit into from
Apr 12, 2025

Conversation

wtgee
Copy link
Member

@wtgee wtgee commented Apr 9, 2025

Adds a new alignment procedure that simply takes three different images (home, 5 seconds to east, 5 seconds to west), identified the same star in each of the three images, and computes the circle of rotation for the mount and gives offsets.

Replaces #1306 #1307
Closes #1304

image

Copy link

codecov bot commented Apr 9, 2025

Codecov Report

Attention: Patch coverage is 15.18325% with 162 lines in your changes missing coverage. Please review.

Project coverage is 67.63%. Comparing base (f665383) to head (40b5e70).
Report is 21 commits behind head on develop.

Files with missing lines Patch % Lines
src/panoptes/pocs/utils/alignment.py 19.04% 102 Missing ⚠️
src/panoptes/pocs/utils/cli/run.py 7.69% 60 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1308      +/-   ##
===========================================
- Coverage    70.36%   67.63%   -2.74%     
===========================================
  Files          101      102       +1     
  Lines         8568     8994     +426     
  Branches       719      756      +37     
===========================================
+ Hits          6029     6083      +54     
- Misses        2389     2761     +372     
  Partials       150      150              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wtgee wtgee added the Hardware Testing For use with PRs that are waiting on hardware tests. label Apr 11, 2025
@wtgee wtgee merged commit a8a3bfc into develop Apr 12, 2025
3 of 5 checks passed
@wtgee wtgee deleted the new-polar-alignment branch April 12, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Hardware Testing For use with PRs that are waiting on hardware tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update old drift align to show offsets in degrees/arcsecs in addition to pixels
1 participant