Skip to content

7.0.0-beta.1: AK template can no longer be customised #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rshearman opened this issue Feb 7, 2022 · 1 comment · Fixed by #323
Closed

7.0.0-beta.1: AK template can no longer be customised #322

rshearman opened this issue Feb 7, 2022 · 1 comment · Fixed by #323

Comments

@rshearman
Copy link
Contributor

rshearman commented Feb 7, 2022

Post commit a4dbdc7, the create_ak API no longer supports customising the key beyond its object attributes. This is due to the following change:

-    };
-
-    let key_builder = if let Some(ref k) = key_customization {
-        k.template(key_builder)
-    } else {
-        key_builder
-    };
-
-    key_builder.build()
+    }

I don't know if this was intentional or not, but if it is then it's probably worth documenting that the key customisation template method won't be called.

Cc: @Superhepper

@rshearman rshearman mentioned this issue Feb 7, 2022
16 tasks
@ionut-arm
Copy link
Member

Thanks for the report, let me try to quickly update that.

ionut-arm added a commit to ionut-arm/rust-tss-esapi that referenced this issue Feb 7, 2022
Following feedback from parallaxsecond#322, this reintroduces customization for AK
public objects in the abstraction layer.
`Hash` is also added to the derive list of `EccCurveIdentifier`.

Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants