Skip to content

Improve usage of unwrap and expect #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2019
Merged

Improve usage of unwrap and expect #17

merged 1 commit into from
Dec 18, 2019

Conversation

ionut-arm
Copy link
Member

This commit looks at improving our usage of unwrap and expect and
the errors they could return instead. Calls that could legitimately
panic during execution were changed to return an error. The rest
were commented to specify why they shouldn't fail in a normal
execution environment.

@ionut-arm
Improve usage of unwrap and expect
146c270 
This commit looks at improving our usage of unwrap and expect and
the errors they could return instead. Calls that could legitimately
panic during execution were changed to return an error. The rest
were commented to specify why they shouldn't fail in a normal
execution environment.

Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
@ionut-arm ionut-arm added bug Something isn't working enhancement New feature or request labels Dec 17, 2019
@ionut-arm ionut-arm added this to the Rust tss-esapi v1.0 milestone Dec 17, 2019
@ionut-arm ionut-arm requested a review from hug-dev December 17, 2019 16:32
@ionut-arm ionut-arm self-assigned this Dec 17, 2019
@hug-dev
Copy link
Member

hug-dev commented Dec 18, 2019

Great! That should fix #2

@ionut-arm
Copy link
Member Author

Great! That should fix #2

I'm still looking through our usage of unsafe blocks, will see if anything else is needed to close #2

@ionut-arm ionut-arm merged commit ad1efa0 into parallaxsecond:master Dec 18, 2019
@ionut-arm ionut-arm deleted the unwrap_expect branch December 18, 2019 11:35
tgonzalezorlandoarm pushed a commit to tgonzalezorlandoarm/rust-tss-esapi that referenced this pull request Mar 14, 2024
@ionut-arm
Merge pull request parallaxsecond#17 from docker/integration
7d84ba8 
Merge Integration into Master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hug-dev hug-dev hug-dev approved these changes

Assignees

@ionut-arm ionut-arm

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
Rust tss-esapi v1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ionut-arm @hug-dev