Ensure PcrSelectionList retains order, #2 #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PcrSelectionList would (possibly) reorder and merge the different TPML_PCR_SELECTION entries. This is not valid in the case where for example the PcrSelectionList is the result of a pcr_read() call: in that case, the actual PCR values are in the same order as the TPML_PRC_SELECTION entries. This means that "subtracting" a PcrSelectionList becomes practically impossible. Signed-off-by: Patrick Uiterwijk <patrick@puiterwijk.org>
Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
hug-dev
approved these changes
Aug 2, 2021
tgonzalezorlandoarm
pushed a commit
to tgonzalezorlandoarm/rust-tss-esapi
that referenced
this pull request
Mar 14, 2024
…te_key_support Import private key support for TPM provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've taken @puiterwijk's PR, fixed the merge conflict and added a small clippy "fix" (the lint was removed/made conditional).