Add builder methods and move NvPublic #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Superhepper
reviewed
Jan 21, 2022
Superhepper
reviewed
Jan 21, 2022
ionut-arm
force-pushed
the
builder-method
branch
from
c3f39ab to
f89dc63
Compare
This commit brings two changes: * implementing `builder` methods on all types that have their own `...Builder` type, so that users are more easily directed to them in the documentation. * moving the `nv` top-level module within the `structures` module to make things a bit more consistent. Signed-off-by: Ionut Mihalcea <ionut.mihalcea@arm.com>
I've now made all the |
wiktor-k
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit brings two changes:
buildermethods on all types that have their own...Buildertype, so that users are more easily directed to them in thedocumentation.
nvtop-level module within thestructuresmodule tomake things a bit more consistent.
Signed-off-by: Ionut Mihalcea ionut.mihalcea@arm.com