Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #66 update readme #67

Merged
merged 1 commit into from
Sep 23, 2021
Merged

fix #66 update readme #67

merged 1 commit into from
Sep 23, 2021
+54 −8

Conversation

prybalko
Copy link
Contributor

Add useful information to README about the project.

The description was taken from
https://docs.google.com/document/d/1eQ6VaKVs3Sn9we2fs2NRAljALsJd6BH12rGGhwAUAX0/edit#

@prybalko prybalko requested review from kirushik and vas3k September 21, 2021 09:32
TarikGul
TarikGul reviewed Sep 21, 2021
View reviewed changes
TarikGul
TarikGul reviewed Sep 21, 2021
View reviewed changes
TarikGul
TarikGul previously approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some small suggestions.

It might also be worth noting the cryptography used for encryption. For example: scrypt is used for key derivation, and xsalsa20-poly1305 is used for encryption-authentication.

kirushik
kirushik previously approved these changes Sep 21, 2021
View reviewed changes
@prybalko
fix #66 update readme

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
697b435
@prybalko prybalko dismissed stale reviews from kirushik and TarikGul via 697b435 September 22, 2021 11:00
@prybalko
Copy link
Contributor Author

It might also be worth noting the cryptography used for encryption. For example: scrypt is used for key derivation, and xsalsa20-poly1305 is used for encryption-authentication.

I'm not sure whether it's an important product feature or a minor implementation detail.
cc: @kirushik

@prybalko prybalko merged commit 9adb6f9 into master Sep 23, 2021
@prybalko prybalko deleted the update-readme branch September 23, 2021 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vas3k vas3k

@TarikGul TarikGul

@kirushik kirushik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@prybalko @kirushik @vas3k @TarikGul