-
-
Notifications
You must be signed in to change notification settings - Fork 878
tvOS push support #1375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tvOS push support #1375
Conversation
…should also be availible for tvos
…rver adapter uses this nomenclature
@flovilmart Any idea whats wrong with the macos CI build? The rest i could reproduce and fix but this one I can't make heads or tails of. It seems only the keychain related tests fail. They run fine on two macs I tried them on. |
Not sure why they fail, requires a deeper investigation / changing the perhaps the toolchain for testing. For now we can ignore I think. I’ll give a look to your patch over the weekend. |
Ok, so because there is no CI test of the tvOS, we cannot asses this works as expected. I assume you have some example working of edge to edge tests @toto? |
@flovilmart I have an installation with ~1.6k devices running iOS and tvOS successfully registering and pushing. I will also test macOS just be sure |
@toto this is awesome!!!! |
Thanks for getting it in! |
@flovilmart Also added the PR for a tiny docs improvement. Would have saved me an hour of digging though the server source code: parse-community/docs#577 |
This is a continuation of an old PR for tvOS support: #1238
This is important since tvOS does now support a few of APNS push features:
content-availible
)The code has been tested end to end and does work for both conditions using a vanilla
parse-server
. Note the config section below though.Changes
PFInstallation
and friends to be used on tvOS by removing unavailable markers.applicationBadge
now as well. So the logic for that should also work on tvOS as well.containingApplicationBundleIdentifier
andapplicationGroupIdentifier
.deviceType
for Apple TV apps is nowtvos
notappletv
to make it compatible with the currentparse-server-push-adapter
Config
To make pushes to tvOS work, a section
tvos
needs to be added to theparse-server
config. It should look exactly like theios
section. This should probably be added to the parse-server docs.Notes on other Parse components
parse-server-push-adapter
usestvos
as adeviceType
(see here: https://github.com/parse-community/parse-server-push-adapter/blob/e7f9bc45339ed8bcbb7dfca9d092e54bddeee95c/src/ParsePushAdapter.js#L28). Therefore this PR changes the registration of tvOS devices totvos
fromappletv
parse-dashboard
so you can targettvos
via the GUI: Add tvOS support to push targeting parse-dashboard#936