Skip to content

tvOS push support #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 10, 2018
Merged

tvOS push support #1375

merged 11 commits into from
Dec 10, 2018

Conversation

toto
Copy link
Contributor

@toto toto commented Dec 5, 2018

This is a continuation of an old PR for tvOS support: #1238

This is important since tvOS does now support a few of APNS push features:

  • background refresh (aka content-availible)
  • setting a badge

The code has been tested end to end and does work for both conditions using a vanilla parse-server. Note the config section below though.

Changes

  • Mostly allows PFInstallation and friends to be used on tvOS by removing unavailable markers.
  • Takes into account that tvOS has a applicationBadge now as well. So the logic for that should also work on tvOS as well.
  • Since tvOS apps also can have extensions (namely top-shelve extensions) also allow
    containingApplicationBundleIdentifier and applicationGroupIdentifier.
  • deviceType for Apple TV apps is now tvos not appletv to make it compatible with the current parse-server-push-adapter

Config

To make pushes to tvOS work, a section tvos needs to be added to the parse-server config. It should look exactly like the ios section. This should probably be added to the parse-server docs.

Notes on other Parse components

@toto
Copy link
Contributor Author

toto commented Dec 7, 2018

@flovilmart Any idea whats wrong with the macos CI build? The rest i could reproduce and fix but this one I can't make heads or tails of. It seems only the keychain related tests fail. They run fine on two macs I tried them on.

@flovilmart
Copy link
Contributor

Not sure why they fail, requires a deeper investigation / changing the perhaps the toolchain for testing. For now we can ignore I think. I’ll give a look to your patch over the weekend.

@flovilmart
Copy link
Contributor

Ok, so because there is no CI test of the tvOS, we cannot asses this works as expected. I assume you have some example working of edge to edge tests @toto?

@toto
Copy link
Contributor Author

toto commented Dec 10, 2018

@flovilmart I have an installation with ~1.6k devices running iOS and tvOS successfully registering and pushing. I will also test macOS just be sure

@flovilmart
Copy link
Contributor

@toto this is awesome!!!!

@flovilmart flovilmart merged commit ad1fea4 into parse-community:master Dec 10, 2018
@flovilmart
Copy link
Contributor

Thanks for getting it in!

@toto
Copy link
Contributor Author

toto commented Dec 10, 2018

@flovilmart Also added the PR for a tiny docs improvement. Would have saved me an hour of digging though the server source code: parse-community/docs#577

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants