Converting TwitterUtils to WKWebView #1511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. If you believe it should stay open, please let us know! As always, we encourage contributions, check out the Contributing Guide |
|
I am waiting for my build PR before I can finish this out. |
* Handles the async action in Parse initialize. Fires a notification when it's done. * Removes failing TwitterUtils test * Fixes a timing issue * Improves reliability of testFetchPin * Adds OCMock as a dependency to our test targets. Fixes the ominous build warning. * Removes call to OCMock stopMocking in PFTestCase It's generally advised in the OCMock docs not to call it. Tests don't seem to break if we don't have it, so it appears we don't need to call it. * Re-adds testRotation but skips. So we remember it.
* Adds Sign in with Apple button to login view * Adds initial Apple sign in logic * Removes unused protocols * Registers Apple auth delegate * Main use thread on callback * Adds Apple icons Adds usage information for convert_images.rb script * Adds tests for Apple login method * Tweaks * Cleans up ParseUI dependencies * Enables tests of 'Sign in with Apple' logic in CI * Removes 'Frameworks' folder from workspace root It was the cause of the stack of warnings that came with every build. * Removes tests from Cocoapods output * Fixes naming * Removes my dev team from signing * Update cocoapods to 1.9.3 and travis to XCode 11.6 * Revert "Update cocoapods to 1.9.3 and travis to XCode 11.6" This reverts commit 50a5390. * Removes comments Co-authored-by: Nathan Kellert <nathankellert@gmail.com>
…y/Parse-SDK-iOS-OSX into Twitter-WKWebView
|
We should get this in a release very soon. @noobs2ninjas Are you around? This looks good to me. |
drdaz
approved these changes
Aug 21, 2020
mtrezza
added
type:feature
|
The label |
parse-github-assistant
bot
removed
the
type:feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.