Skip to content

fix: upgrade graphql from 14.6.0 to 15.5.1 #1752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

snyk-bot
Copy link
Contributor

@snyk-bot snyk-bot commented Aug 4, 2021

Snyk has created this PR to upgrade graphql from 14.6.0 to 15.5.1.

merge advice
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


Warning: This is a major version upgrade, and may be a breaking change.

  • The recommended version is 13 versions ahead of your current version.
  • The recommended version was released a month ago, on 2021-06-20.
Release notes
Package name: graphql from graphql GitHub release notes

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

🧐 View latest project report

🛠 Adjust upgrade PR settings

🔕 Ignore this dependency or unsubscribe from future upgrade PRs

@mtrezza mtrezza mentioned this pull request Aug 19, 2021
3 tasks
@mtrezza mtrezza mentioned this pull request Sep 4, 2021
@mtrezza mtrezza changed the title [Snyk] Upgrade graphql from 14.6.0 to 15.5.1 fix: upgrade graphql from 14.6.0 to 15.5.1 Sep 19, 2021
@dblythy
Copy link
Member

dblythy commented Sep 19, 2021

@mtrezza what do we need to do to get this merged? I would like to get this working on NPM 7 😊

@mtrezza
Copy link
Member

mtrezza commented Sep 19, 2021

Well, the tests need to pass. It appears that dashboard needs some refactoring for that.

@dblythy
Copy link
Member

dblythy commented Sep 19, 2021

Right, I understand. I'll look into it.

@mtrezza
Copy link
Member

mtrezza commented Sep 19, 2021

If I recall correctly, the issue is related to webpack. There is some incompatibility with dependencies that come with this upgrade. Dashboard has many dev dependencies out of date, and upgrading them is like a chain reaction. But maybe you can find a way to just upgrade the necessary and maybe not to the latest release.

@mtrezza
Copy link
Member

mtrezza commented Sep 23, 2021

Closing as this will be upgraded with #1807

@mtrezza mtrezza closed this Sep 23, 2021
@mtrezza mtrezza deleted the snyk-upgrade-e8337b670231fdb9253b7c0bb3d81c34 branch September 23, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants