-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix: Data loading indicator not showing when using pagination #2768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Data loading indicator not showing when using pagination #2768
Conversation
🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review. |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
Uffizzi Ephemeral Environment
|
# [7.1.0-alpha.11](7.1.0-alpha.10...7.1.0-alpha.11) (2025-04-28) ### Bug Fixes * Data loading indicator not showing when using pagination ([#2768](#2768)) ([62d7aec](62d7aec))
🎉 This change has been released in version 7.1.0-alpha.11 |
Warning Rate limit exceeded@parseplatformorg has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 26 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe changes introduce explicit management of a loading state within the data fetching logic of the data browser. The Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DataBrowser
participant DataBrowserTable
participant DataBrowserHeaderBar
User->>DataBrowser: Initiate page navigation
DataBrowser->>DataBrowser: Set isLoading = true, data = null
DataBrowser->>DataBrowser: Fetch data
DataBrowser->>DataBrowserTable: Pass isLoading prop
DataBrowserTable->>DataBrowserHeaderBar: Pass isDataLoaded = !isLoading
DataBrowser-->>User: (UI shows loading indicator)
DataBrowser->>DataBrowser: On fetch complete, set isLoading = false, set data
DataBrowser->>DataBrowserTable: Pass isLoading = false
DataBrowserTable->>DataBrowserHeaderBar: Pass isDataLoaded = true
DataBrowser-->>User: (UI shows loaded data)
Assessment against linked issues
Poem
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
# [7.1.0](7.0.0...7.1.0) (2025-05-01) ### Bug Fixes * Clicking on pointer in data browser when using pagination does not reset to first page ([#2767](#2767)) ([ab512e5](ab512e5)) * Dashboard crashes on login due to `passport` upgrade ([#2758](#2758)) ([ee74321](ee74321)) * Dashboard crashes when selecting app ([#2747](#2747)) ([8b0cfea](8b0cfea)) * Data browser filters "key exists" and "key does not exist" not working ([#2760](#2760)) ([0691b3c](0691b3c)) * Data browser filters "key exists" and "key does not exist" not working ([#2762](#2762)) ([099eca3](099eca3)) * Data loading indicator not showing when using pagination ([#2768](#2768)) ([62d7aec](62d7aec)) * Improperly aligned unfolding sub-items in context menu in data browser ([#2713](#2713)) ([189c817](189c817)) * Logout bar layout not aligned with data browser navigation bar ([#2720](#2720)) ([01a2a1c](01a2a1c)) * Navigation bar in data browser is transparent and partly covers info panel ([#2717](#2717)) ([60b38a5](60b38a5)) * Obsolete, long-running data fetch request overrides displayed data of newer fetch request in the data browser ([#2715](#2715)) ([31668eb](31668eb)) ### Features * Add pagination to data browser ([#2659](#2659)) ([a3c8a11](a3c8a11)) * Allow row selection in data browser by dragging mouse outside of selection box column ([#2716](#2716)) ([7c0f607](7c0f607)) * Display filter list in data browser sorted alphabetically ([#2761](#2761)) ([0209a0d](0209a0d))
🎉 This change has been released in version 7.1.0 |
* source: (58 commits) chore(release): 7.1.0 [skip ci] empty commit to trigger CI refactor: Bump webpack-cli from 5.0.1 to 6.0.1 (parse-community#2772) refactor: Bump @babel/plugin-proposal-decorators from 7.20.13 to 7.25.9 (parse-community#2773) refactor: Bump eslint-plugin-react from 7.37.4 to 7.37.5 (parse-community#2764) chore(release): 7.1.0-alpha.12 [skip ci] fix: Clicking on pointer in data browser when using pagination does not reset to first page (parse-community#2767) chore(release): 7.1.0-alpha.11 [skip ci] fix: Data loading indicator not showing when using pagination (parse-community#2768) chore(release): 7.1.0-alpha.10 [skip ci] fix: Data browser filters "key exists" and "key does not exist" not working (parse-community#2762) refactor: Bump puppeteer from 24.6.0 to 24.6.1 (parse-community#2750) chore(release): 7.1.0-alpha.9 [skip ci] feat: Display filter list in data browser sorted alphabetically (parse-community#2761) chore(release): 7.1.0-alpha.8 [skip ci] fix: Data browser filters "key exists" and "key does not exist" not working (parse-community#2760) chore(release): 7.1.0-alpha.7 [skip ci] fix: Dashboard crashes on login due to `passport` upgrade (parse-community#2758) refactor: Bump http-server from 14.0.0 to 14.1.1 (parse-community#2757) refactor: Bump webpack from 5.94.0 to 5.99.5 (parse-community#2751) ...
New Pull Request Checklist
Issue Description
Closes: #2718
Approach
TODOs before merging
Summary by CodeRabbit
New Features
Bug Fixes