Skip to content

Add performance impact CI step #7610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
3 tasks done
mtrezza opened this issue Oct 9, 2021 · 5 comments
Open
3 tasks done

Add performance impact CI step #7610

mtrezza opened this issue Oct 9, 2021 · 5 comments
Labels
bounty:$100 Bounty applies for fixing this issue (Parse Bounty Program) type:ci CI related issue

Comments

@mtrezza
Copy link
Member

mtrezza commented Oct 9, 2021

New Feature / Enhancement Checklist

Current Limitation

Parse Server has no CI check to compare performance impact of a PR before merging.

Feature / Enhancement Description

Add performance impact CI check to validate a positive / prevent negative performance impact of a change.

  • The perf impact should be displayed inside the PR thread, either as a check status message with link to a more detailed page, or an auto-updated comment.
  • There are some internal tools available such as the Parse GitHub Assistant that could run a performance script on a branch and update a CI check accordingly.
  • If you want to take on this issue as part of the Bounty Program, it is recommended to begin a discussion about how to design and implement this.

Example Use Case

n/a

Alternatives / Workarounds

n/a

@parse-github-assistant
Copy link

parse-github-assistant bot commented Oct 9, 2021

Thanks for opening this issue!

  • 🎉 We are excited about your ideas for improvement!

@mtrezza mtrezza added the type:ci CI related issue label Oct 9, 2021
@mtrezza
Copy link
Member Author

mtrezza commented Oct 14, 2021

Possibly this:
https://github.com/marketplace/actions/continuous-benchmark
benchmark-action/github-action-benchmark#68

We can simply use the perf measure API of Node 16 and the tool above can read and process it.

@dplewis Could that replace our internal benchmark tool?

@mtrezza mtrezza added the bounty:$100 Bounty applies for fixing this issue (Parse Bounty Program) label Oct 14, 2021
@mtrezza mtrezza pinned this issue Mar 27, 2022
@mtrezza mtrezza unpinned this issue Mar 28, 2022
@dblythy
Copy link
Member

dblythy commented Mar 8, 2023

Possibly a duplicate of #7610

@mtrezza
Copy link
Member Author

mtrezza commented Mar 8, 2023

This is #7610 🙃

@dblythy
Copy link
Member

dblythy commented Mar 8, 2023

Oops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty:$100 Bounty applies for fixing this issue (Parse Bounty Program) type:ci CI related issue
Projects
None yet
Development

No branches or pull requests

2 participants