Stop requiring verifyUserEmails for password reset functionality #2166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
TylerBrock
force-pushed
the
verify-user-emails-fix
branch
from
e9dc4f1 to
12d4b15
Compare
|
@TylerBrock updated the pull request. |
|
LGTM! |
rsouzas
pushed a commit
to back4app/parse-server
that referenced
this pull request
Mar 15, 2017
rsouzas
pushed a commit
to back4app/parse-server
that referenced
this pull request
Mar 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows password reset to work without requiring
verifyUserEmailsbe true.Currently, parse-server users verifyUserEmails within
Config.validateEmailConfiguration()as a proxy for determining if an e-mail adapter was provided. That is not so great as verification of user e-mails should not be required for other e-mail based functionality to work.Additionally this removes a hack and actually fixes the root cause of the bug in #1649 where we must verify that that
appNameis set for e-mail functionality to work. The spirit of the regression test for #1649 should be to check if appName is not set and fail instead of simply checking if verifyUserEmails is true.Background: Our application uses password reset extensively but has a sign up flow that does not involve e-mail at all. It is imperative to us that password reset work without verifyUserEmails being set to true.