Adds endpoint for non-revocable session token upgrade #2646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Current coverage is 92.16% (diff: 93.33%)@@ master #2646 diff @@
==========================================
Files 99 99
Lines 12113 12166 +53
Methods 1488 1495 +7
Messages 0 0
Branches 1996 1999 +3
==========================================
+ Hits 11154 11213 +59
+ Misses 959 953 -6
Partials 0 0
|
|
@flovilmart updated the pull request - view changes |
flovilmart
force-pushed
the
revocable-session-endpoint
branch
from
0138070 to
e855c1a
Compare
| // handle the upgradeToRevocableSession path on it's own | ||
| if (info.sessionToken && | ||
| req.url === '/upgradeToRevocableSession' && | ||
| info.sessionToken.indexOf('r:') != 0) { |
There was a problem hiding this comment.
Doesn't the presence of r: in the session token indicate non-legacy?
There was a problem hiding this comment.
Yes, that's why != 0 as if it's revocable, it's gonna be at that index.
There was a problem hiding this comment.
Ah doh, I misread :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Better support for upgrading to revocable session after migration has occurred.
Fixes #2255