Skip to content

Return success on sendPasswordResetEmail even if email not found. #5103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2018
Merged

Return success on sendPasswordResetEmail even if email not found. #5103

merged 1 commit into from
Oct 5, 2018

Conversation

acinader
Copy link
Contributor

@acinader acinader commented Oct 5, 2018

fixes: #5102

@acinader acinader requested a review from flovilmart October 5, 2018 16:34
@codecov
Copy link

codecov bot commented Oct 5, 2018 •
edited
Loading

Codecov Report

Merging #5103 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5103      +/-   ##
==========================================
+ Coverage    93.7%   93.72%   +0.02%     
==========================================
  Files         123      123              
  Lines        8879     8879              
==========================================
+ Hits         8320     8322       +2     
+ Misses        559      557       -2
Impacted Files Coverage Δ
src/Routers/UsersRouter.js 93.46% <0%> (ø) ⬆️
src/RestWrite.js 93.33% <0%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a01fa0...4c08a65. Read the comment docs.

@acinader acinader merged commit 7fe4030 into parse-community:master Oct 5, 2018
@acinader acinader deleted the email-enumeration branch October 5, 2018 17:03
acinader added a commit to acinader/parse-php-sdk that referenced this pull request Jan 30, 2019
@acinader
Remove a test that is no longer relevent. See:
3afd562 
parse-community/parse-server#5103
@acinader acinader mentioned this pull request Jan 30, 2019
Merged
@TomWFox TomWFox mentioned this pull request May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flovilmart flovilmart flovilmart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User Enumeration possible on passwordReset endpoint
2 participants
@acinader @flovilmart