-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
GraphQL DX: Relation/Pointer #5946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GraphQL DX: Relation/Pointer #5946
Conversation
822c4c4
to
3b84b7c
Compare
Codecov Report
@@ Coverage Diff @@
## master #5946 +/- ##
=========================================
- Coverage 93.68% 93.6% -0.09%
=========================================
Files 156 156
Lines 10850 10897 +47
=========================================
+ Hits 10165 10200 +35
- Misses 685 697 +12
Continue to review full report at Codecov.
|
|
@davimacedo ready for review 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks really good to me! I only left two small comments. @douglasmuraoka do you want to take a look as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me. @douglasmuraoka can you please also take a look?
@Moumouls I've tried some operations, such as updating an object removing one element from the relation and linking a pointer, and I got the following error (although the operation worked):
Query:
Could you please take a look? |
Strange, the test for The error appear on each operation ? |
The test
|
Fixed, the issue was introduced in #5893 |
* Add a test on deep complex GraphQL Query * Relation/Pointer new DX + deep nested mutations * Fix lint * Review * Remove unnecessary code * Fix objectId on update
#5863
Relation
Pointer