Skip to content

Remove duplicate CHANGELOG for Parse.Cloud.sendEmail #7188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2021
Merged

Remove duplicate CHANGELOG for Parse.Cloud.sendEmail #7188

merged 2 commits into from
Feb 15, 2021

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Feb 13, 2021

New Pull Request Checklist

Issue Description

I accidentally entered sendEmail twice in the CHANGELOG.

Related issue: -

Approach

TODOs before merging

@codecov
Copy link

codecov bot commented Feb 13, 2021 •
edited
Loading

Codecov Report

Merging #7188 (68d6f84) into master (3d76643) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #7188   +/-   ##
=======================================
  Coverage   94.04%   94.04%           
=======================================
  Files         172      172           
  Lines       12850    12850           
=======================================
  Hits        12085    12085           
  Misses        765      765
Impacted Files Coverage Δ
src/Controllers/DatabaseController.js 95.46% <0.00%> (-0.15%) ⬇️
src/Adapters/Files/GridFSBucketAdapter.js 80.32% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d76643...706314a. Read the comment docs.

@mtrezza
Copy link
Member

mtrezza commented Feb 13, 2021 •
edited
Loading

Would you mind also ordering the entries in change log master section?
I already did that, but we have no guideline regarding this yet.

I think this order makes most sense:

  • New (experimental)
  • New
  • Improve
  • Fix

We should also only use these labels for consistency.

@dblythy
Copy link
Member Author

dblythy commented Feb 13, 2021 •
edited
Loading

Would you mind also ordering the entries in change log master section?

Easy, i've also added a comment up the top for future contributors.

@mtrezza
Copy link
Member

mtrezza commented Feb 13, 2021

Nice! Thanks!

davimacedo
davimacedo approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@davimacedo davimacedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davimacedo davimacedo merged commit d42e3a1 into parse-community:master Feb 15, 2021
dplewis pushed a commit that referenced this pull request Feb 21, 2021
@dblythy @dplewis
Remove duplicate CHANGELOG for Parse.Cloud.sendEmail (#7188)
1d5da6a 
* Update CHANGELOG.md

* Update CHANGELOG.md
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davimacedo davimacedo davimacedo approved these changes

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dblythy @mtrezza @parseplatformorg @davimacedo