ci: reduce timeout after idempotency tests #8227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening this pull request!
|
Codecov ReportBase: 94.11% // Head: 94.11% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## alpha #8227 +/- ##
=======================================
Coverage 94.11% 94.11%
=======================================
Files 182 182
Lines 13770 13770
=======================================
Hits 12960 12960
Misses 810 810
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@dblythy is this ready for review? |
|
Yes, apologies |
|
🎉 This change has been released in version 5.3.0-alpha.30 |
|
🎉 This change has been released in version 5.4.0-beta.1 |
|
🎉 This change has been released in version 5.4.0-alpha.1 |
|
🎉 This change has been released in version 5.4.0 |
|
🎉 This change has been released in version 5.4.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
Related issue: n/a
Approach
Idempotency tests mutate
DEFAULT_TIMEOUT_INTERVALto 3 and a half minutes, so any tests thereafter will maintain that timeout. This means that if 3-5 tests timeout, the whole test suite will stop (as it's limited to 15 minutes).This PR sets the timeout back to the default after the Idempotency tests.
TODOs before merging