Skip to content

fix: Unable to create new role if beforeSave hook exists #8476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

yog27ray
Copy link
Contributor

Unable to save role when before save hook is present on role.

Closes: #8473

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

@parse-github-assistant
Copy link

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch coverage: 23.52% and project coverage change: -0.52 ⚠️

Comparison is base (4ce135a) 94.30% compared to head (58d44bf) 93.79%.

❗ Current head 58d44bf differs from pull request most recent head 86bd690. Consider uploading reports for the commit 86bd690 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8476      +/-   ##
==========================================
- Coverage   94.30%   93.79%   -0.52%     
==========================================
  Files         183      183              
  Lines       14484    14501      +17     
==========================================
- Hits        13659    13601      -58     
- Misses        825      900      +75     
Impacted Files Coverage Δ
src/Options/Definitions.js 100.00% <ø> (ø)
src/Options/index.js 100.00% <ø> (ø)
src/middlewares.js 92.64% <23.52%> (-4.17%) ⬇️

... and 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza
Copy link
Member

mtrezza commented Mar 10, 2023

Closing as issue only occurs on 5.x LTS branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error "Tried to create an ACL with an invalid permission type."
2 participants