feat: distinct error for unverified email login #11647
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds a new error to be thrown when logging in while having
verify: true
set but no email has been verified for the user yet.Why?
To have a more descriptive, actionable error thrown in this case as opposed to the generic "Invalid email or password." This gives users more insight into why the login failed.
How?
Introducing a new error:
UnverifiedEmail
and adjusting the check to be separate fromif (!user) { ... }
.Fixes #11358
Notes:
/test/auth/int.spec.ts
for this, however whenever I try to commit it I get an error stating that theeslint@9.14.0
module was not found duringlint-staged
.Int test
Demo of toast:
