Fix: PHP 8.1 pgsql change of return values #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per https://php.watch/versions/8.1/PgSQL-resource, PostgreSQL extension has moved away from resource objects and is now returning opaque classes (PgSQL\Connection, Result, Lob). These classes no longer provide default conversions to (int), so a different approach is required, while maintaining compatibility to older PHP versions.
|
Sourcecode changes looks good to me. I haven´t got any postgre database at the moment, but if there is anybody who can approve the funcionality, i will merge this PR in the master branch. |
My previous commit did not check for the right result structure before raising an exception. While looking into this, I have found a deprecation issue with Postgresql server versions >= 12 that needed fixing as well (adsrc column was removed). Context and recommended replacement: https://www.postgresql.org/docs/12/release-12.html#:~:text=obsolete%20pg_attrdef.-,adsrc,-column%20(Peter%20Eisentraut
|
My dev team looked at the code, and it's in line with what was found when we first encountered the problem with pear and PHP >= 8.1. So look's good enough for me ! |
MarkMaldaba
suggested changes
Apr 29, 2025
DB/pgsql.php
Outdated
|
|
||
| if (function_exists('pg_version')) { | ||
| $pg_ver = pg_version($this->connection); | ||
| $this->pg_major_server_version = intval($pg_ver['server'] ?? 0); |
There was a problem hiding this comment.
The null coalescing operator requires PHP 7 or above, so can't be used here.
MarkMaldaba
reviewed
Apr 30, 2025
MarkMaldaba
approved these changes
Apr 30, 2025
|
I tested it (not that I'm more of a sysadmin than a dev), and I no longer have warnings with simple selects. |
schengawegga
requested changes
Apr 30, 2025
This completes the decision tree related to handling pg_() internal functions return types and function availability based on PHP versions. The statement is not normally expected to be executed with any current or historical PHP version, but having it seems like a good idea, at least for completeness.
schengawegga
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://php.watch/versions/8.1/PgSQL-resource, PostgreSQL
extension has moved away from resource objects and is now
returning opaque classes (PgSQL\Connection, Result, Lob).
These classes no longer provide default conversions to (int), so
a different approach is required, while maintaining compatibility
to older PHP versions.