Skip to content

HTTP_Request2_ConnectionException since v2.4.0 #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
beephotography opened this issue Jul 30, 2020 · 2 comments
Closed

HTTP_Request2_ConnectionException since v2.4.0 #20

beephotography opened this issue Jul 30, 2020 · 2 comments
Assignees

Comments

@beephotography
Copy link

Hi there,

since updating to v2.4.0 we have problems connecting from our local docker-environment to external APIs through our network proxy.

We receive a message Failed to enable secure connection when connecting through proxy when connecting.

With v2.3.0 everything worked fine (with our exact same proxy configuration)

Unfortunately I can't give some more hints.

Can somebody investigate this problem or give any workaround?

Regards
Andy

@beephotography
Copy link
Author

beephotography commented Jul 30, 2020

UPDATE:

It seems that it could have something to do with the following line:

        // Run socket in non-blocking mode, to prevent possible problems with
        // HTTPS requests not timing out properly (see bug #21229)
        stream_set_blocking($this->socket, false);

in File vendor/pear/http_request2/HTTP/Request2/SocketWrapper.php (line 134)

When I comment out this line with v2.4.0 it works again. Comment in: breaks again.

@sad-spirit sad-spirit self-assigned this Jul 30, 2020
@sad-spirit
Copy link
Member

Oops, looks like it's even mentioned in PHP doc comments
https://www.php.net/manual/en/function.stream-socket-enable-crypto.php#75442

Thanks for the report, will fix ASAP.

netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this issue Oct 4, 2020
Update pear-HTTP_Request2 package to 2.4.2.


Update

2.4.2 (2020-09-24 18:13 UTC)

Changelog:

Socket adapter could prematurely end receiving the response body due to
fread() call returning an empty string


2.4.1 (2020-08-01 05:16 UTC)

Changelog:

Switch socket to blocking mode when enabling crypto, this fixes HTTPS
requests through proxy with Socket adapter
pear/HTTP_Request2#20


2.4.0 (2020-07-26 13:43 UTC)

Changelog:

* Minimum required version is now PHP 5.6, as using older versions for HTTPS
  requests may be insecure

* Removed support for magic_quotes_runtime, as get_magic_quotes_runtime()
  was deprecated in PHP 7.4 and the functionality itself was disabled since
  PHP 5.4 (bug #23839)

* Socket adapter now uses socket in non-blocking mode, as some configurations
  could have problems with timeouts in HTTPS requests (bug #21229)

* Fixed bogus size check error with gzipped responses larger than 4 GiB
  uncompressed (bug #21239)

* Use current "Intermediate compatibility" cipher list
* Updated Public Suffix List

The package is now 100% autoload-compatible, when installed with composer it
no longer uses include-path and does not contain require_once statements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants