Make HTTP_Request2 PHP 8.1 compatible #25
Comments
|
ERROR: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated on line 379 in file /.../vendor/pear/http_request2/HTTP/Request2/Adapter/Socket.php. |
sad-spirit
added a commit
that referenced
this issue
Jan 5, 2022
|
Released version 2.5.1 that shouldn't produce errors running under PHP 8.1 |
|
Amazing! Thank you very much |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this issue
Jan 10, 2022
2.5.0 (2020-07-12) Fixed * Socket adapter will now retry writing to socket rather than throw an exception if `fwrite()` call returns zero written bytes pear/HTTP_Request2#23 Changed * Socket adapter will use only TLS 1.2 and TLS 1.3 (the latter is available on PHP 7.4+) * Upgraded tests for PHPUnit 9 compatibility, PHPUnit Polyfills package is used to run them on PHP 5.6 to PHP 8 * Test suite now runs on Github Actions rather than on Travis * Updated Public Suffix List 2.5.1 (2021-01-06) * The package runs under PHP 8.1 without `E_DEPRECATED` messages pear/HTTP_Request2#25 * Updated Public Suffix List
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm getting some errors when using in PHP 8.1.x
Like
ERROR: Return type of HTTP_Request2::notify() should either be compatible with SplSubject::notify(): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice on line 749 in file /.../vendor/pear/http_request2/HTTP/Request2.php
ERROR: Return type of HTTP_Request2::detach(SplObserver $observer) should either be compatible with SplSubject::detach(SplObserver $observer): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice on line 736 in file /.../vendor/pear/http_request2/HTTP/Request2.php
ERROR: Return type of HTTP_Request2::attach(SplObserver $observer) should either be compatible with SplSubject::attach(SplObserver $observer): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice on line 721 in file /.../vendor/pear/http_request2/HTTP/Request2.php
These fixes should be trivial
The text was updated successfully, but these errors were encountered: