add icann option

[alsotang]

fix issue #4 #6

[coveralls]

Coverage remained the same at 100.0% when pulling 1c4dda9 on alsotang:master into 525be70 on peerigon:master.

[coveralls]

Coverage remained the same at 100.0% when pulling 1c4dda9 on alsotang:master into 525be70 on peerigon:master.

[alsotang]

ping @jhnns

[coveralls]

Coverage remained the same at 100.0% when pulling e58f2ba on alsotang:master into 525be70 on peerigon:master.

[jhnns]

Awesome, thx! 👍 I was just about to write that for myself :)

I've merged this PR locally because it had a conflict. I'll publish a 1.0.0 tomorrow.

FYI: I've renamed options.icann to options.includePrivateTlds which is false by default. I think, most users would not expect blogspot.com to be a TLD.

[alsotang]

Yeah, I also think most user dont want non-icann tlds. That socall effective-private-tld always make misunderstand.

[alsotang]

can we just name the option private?

[jhnns]

We can name it privateTlds, but private is too generic

[alsotang]

ok, I agree that we should use a non-generic name.

And should we make privateTlds : false a default option?

I think the feature of private tld is unpredictable and obscure. I really doubt that how many people would rely on this feature.

If we still make privateTlds: true default, does the harm of the confusion of new users greater than its compatibility?

[jhnns]

Yes, it should be privateTlds: false by default. I tripped over it too.