Skip to content

Adding statistics for comparing compiled cog methods' code size and metadata size #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: pharo-12
Choose a base branch
from

Conversation

kumom
Copy link
Contributor

@kumom kumom commented May 27, 2025

Changes:

  1. Added statTotalHeaderSize, statTotalCodeSize, statTotalMapSize to Cogit
  2. Added three VM parameters in to obtain these three statistics primitiveGetVMParameter:
  3. Moved primitiveGetVMParameter: from class StackInterpreterPrimitives to CoInterpreterPrimitives because I wanted to access to the cogit instance.
  4. Added label information in parameterLabels (which is not in the VMMaker package)
  5. Changed paramsArraySize from 86 to 89 in primitiveVMParameter (the previous version should have been 87 because there has been 87 parameters before this PR).

Questions:

  1. Should we move parameterLabels to this repo?
  2. Should we move primitiveVMParameter to CoInterpreterPrimitives as well?

@guillep @PalumboN

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not directly related to the purpose of this PR, and it is only here because I was previously cleaning up some code while I was getting familiar with the codebase. This method has no senders, so it should be safe to remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant