Roundtrip Graph imports #838
Conversation
| for (size_t i = 0; i < graph.GetRootRegion().narguments(); ++i) | ||
| { | ||
| auto arg = graph.GetRootRegion().argument(i); | ||
| auto imp = dynamic_cast<llvm::GraphImport *>(arg); |
| return ConvertMlir(block); | ||
| auto & topNode = block->front(); | ||
| auto omegaNode = ::mlir::dyn_cast<::mlir::rvsdg::OmegaNode>(topNode); | ||
| return ConvertOmega(omegaNode); |
There was a problem hiding this comment.
Why has this call to ConvertMlir() been replaced? Isn't the new code identical to the body of ConvertMlir()?
There was a problem hiding this comment.
I have some small suggestions for the code.
One question I have is if the GraphImports you create during MLIR->RVSDG can actually be used. During conversions of blocks, there is a
std::unordered_map<::mlir::Operation *, rvsdg::Node *> operationsMap;for mapping operations, but this map never gets the OmagaArgument and corresponding GraphImports added. Since GraphImport is not a real node, but actually an output*, we might have to change how the mapping is implemented.
To summarize, I do not think MlirToJlmConverter::GetConvertedInputs is currently able to convert usage of OmegaArguments.
Or maybe I am not understanding something?
Requires EECS-NTNU/mlir_rvsdg#8
Graph imports are reprsented by omega argument ops at the beginning of the omega block