多套配置共存及针对Laravel ORM的优化 #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: 增加了多套配置，可以使用client指定使用那套。 php-casbin#8 * refactor: 去掉了在框架初始化的时候就注入监听，改为按需初始化 php-casbin#6 * fix: 去掉了Laravel的缓存，保持和TP一样 php-casbin#7 * refactor: 调整了一些LaravelAdapter里用法。 已知问题： * 测试待补充 * 调整未测试(主要因为着急，本身项目里已造了轮子，所以没拿回去测试)
TP的Adapter初始化传参缺少里第一个空数组
|
@lyt8384 非常感谢。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
已知问题：
测试待补充2.28补充了一些基础测试，并很粗糙的测试了一遍调整未测试(主要因为着急，本身项目里已造了轮子，所以没拿回去测试)虽然做了单元测试，但是比较调整还是很大的可能还是需要有实际使用的同学测试下。建议在开发环境下全面测试一下，蹲一个好心人补全单元测试，现在的覆盖率真的很低很低。