Fix ClassName::beginsWith() #26
Conversation
|
I'm not sure how it should work for PSR-0. |
|
seems to be some test failure and you fixed a couple of phpstan issues so the baseline needs to be updated |
|
tests still failing... |
|
Still failing for mixed PSR0 and PSR4 prefixes. |
|
7.3 failure and CS --- we can drop 7.3 and bump to 7.4 |
|
Currently I do not see any test result on the github side ( |
| ], | ||
| [ | ||
| $this->classLoader->getFallbackDirsPsr4(), | ||
| // PSR0 name inflector works here as there is no prefix | ||
| new Psr0NameInflector(), | ||
| Psr0NameInflector::NAMESPACE_SEPARATOR, |
There was a problem hiding this comment.
hm, why do we pass this in if it's the same each time?
There was a problem hiding this comment.
Not the same: Psr0NameInflector::NAMESPACE_SEPARATOR and Psr4NameInflector::NAMESPACE_SEPARATOR are used as an additional separator.
Such separator would be returned from NameInflector::getAdditionalSeparator() or something similar and the we would not need pass it there. If you agree then I can make this change.
There was a problem hiding this comment.
ah ok, confused though why would \\ be an additional separator for PSR4? but yeah if we could improve the intent of these constnats/and methods it would be good 👍
now that we've merged a PR the CI should run for you by default... 🤞
There was a problem hiding this comment.
Please do not forget to make a release and upgrade it in phpactor while it's not a part of the monolith.
There was a problem hiding this comment.
No description provided.