Skip to content

Tweak and fix the update footer #2745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 15, 2023
Merged

Conversation

yubiuser
Copy link
Member

@yubiuser yubiuser commented Oct 14, 2023

What does this PR aim to accomplish?:

  1. Do not propagate the update status from one component to the next. Reset the variable
  2. Don't link to the release page when not on master but to the commit history
  3. Fix the how-to-update footer
  4. Don't assume there is an update when remote hash is empty (happens on custom branches when the remote branch gets deleted)

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

@yubiuser yubiuser requested a review from a team October 14, 2023 13:16
@yubiuser yubiuser added PR: Approval Required Open Pull Request, needs approval Pi-hole v6.0 labels Oct 14, 2023
@yubiuser
Copy link
Member Author

Maybe someone can test if everything works as expected on docker?

@yubiuser yubiuser force-pushed the tweak/update_footer branch 2 times, most recently from 681ca3d to 9f9f04d Compare October 14, 2023 13:19
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser force-pushed the tweak/update_footer branch from 9f9f04d to d544473 Compare October 14, 2023 13:27
@yubiuser yubiuser marked this pull request as draft October 14, 2023 17:55
Signed-off-by: Christian König <ckoenig@posteo.de>
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser marked this pull request as ready for review October 14, 2023 18:02
@yubiuser yubiuser marked this pull request as draft October 14, 2023 18:04
Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser marked this pull request as ready for review October 14, 2023 18:11
@rdwebdesign
Copy link
Member

I saw a small visual detail:

image

We could add a space before the &middot; character (line 545).

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser
Copy link
Member Author

I added a &nbsp

@yubiuser yubiuser merged commit 21af10a into development-v6 Oct 15, 2023
@yubiuser yubiuser deleted the tweak/update_footer branch October 15, 2023 08:41
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Pi-hole v6.0 PR: Approval Required Open Pull Request, needs approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants