Skip to content

temp.limit needs to be data-type="integer" #2785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

yubiuser
Copy link
Member

What does this PR aim to accomplish?:

Fix the input field of the temp limit from /settings/api. The data-type was missing and the corresponding js did not convert the input to integer.

// If this is an integer number, parse it accordingly
if ($(this).data("type") === "integer") {
value = parseInt(value, 10);
}

Missing this, errors were generated and the new limit was not saved.

023-10-27 12:51:06.960 [282154/T282165] ERR: /api/config: webserver.api.temp.limit invalid: not a number
2023-10-27 12:51:06.961 [282154/T282165] INFO: No config changes detected
2023-10-27 12:51:14.810 [282154/T282166] ERR: /api/config: webserver.api.temp.limit invalid: not a number
2023-10-27 12:51:14.811 [282154/T282166] INFO: No config changes detected
2023-10-27 12:52:07.074 [282154/T282167] INFO: Writing config file
2023-10-27 12:52:28.312 [282154/T282168] ERR: /api/config: webserver.api.temp.limit invalid: not a number
2023-10-27 12:52:28.313 [282154/T282168] INFO: No config changes detected


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: Christian König <ckoenig@posteo.de>
@yubiuser yubiuser requested a review from a team October 27, 2023 11:06
@yubiuser yubiuser merged commit 0cbe31f into development-v6 Oct 27, 2023
@yubiuser yubiuser deleted the fix/temp_limit branch October 27, 2023 14:40
@PromoFaux PromoFaux mentioned this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Saving changes from web interface at /settings/api errors at temp.limit.
2 participants