Skip to content

Translations respect language of user profile #1337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 16, 2025

Conversation

Corepex
Copy link
Contributor

@Corepex Corepex commented Apr 14, 2025

Changes in this pull request

Resolves #1330
Blocked-by: pimcore/studio-backend-bundle#1011

Additional info

This pull request introduces several changes to enhance internationalization, improve API functionality, and update build assets. The key updates include the addition of user-specific language support, new API endpoints for document management, and the replacement of outdated build asset files.

Internationalization Enhancements:

  • Added language property to the initialState in both rtkQueryErrorLogger.ts and user-slice.ts to support user-specific language preferences. [1] [2]
  • Updated the AppLoader component to dynamically load translations based on the user's preferred language and switch the i18n language accordingly. [1] [2]

API Improvements:

  • Introduced a new documentAdd mutation in document-api-slice.gen.ts to enable adding documents via API, along with new types (DocumentAddApiResponse, DocumentAddApiArg, and DocumentAdd) to support this functionality. [1] [2] [3]
  • Removed unused Error and DevError types to clean up the API definitions.
  • Added a new hook, useDocumentAddMutation, for interacting with the documentAdd mutation.

Build Asset Updates:

  • Removed outdated build asset files (entrypoints.json and manifest.json) for previous builds and replaced them with updated versions for the new build (80f3ca92-2343-436f-ad38-339f72f9962c). [1] [2] [3] [4] [5] [6] [7] [8]

@Corepex Corepex self-assigned this Apr 14, 2025
Copy link

@markus-moser markus-moser added this to the next milestone Apr 30, 2025
Corepex and others added 5 commits May 15, 2025 14:26
…ofile

# Conflicts:
#	assets/build/api/docs.jsonopenapi.json
#	assets/js/src/core/modules/auth/authorization-api-slice.gen.ts
#	assets/js/src/core/modules/auth/user/user-api-slice.gen.ts
#	assets/js/src/core/modules/user/user-api-slice.gen.ts
Copy link

sonarqubecloud bot commented May 15, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Corepex Corepex marked this pull request as ready for review May 15, 2025 13:40
@Corepex Corepex requested a review from markus-moser May 15, 2025 13:40
@Corepex Corepex merged commit f2863a3 into 1.x May 16, 2025
1 check passed
@Corepex Corepex deleted the 1330-translations-respect-language-of-user-profile branch May 16, 2025 11:02
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Translations] Respect language of user profile
2 participants