Fixed subicon style in tree #1411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Doesn't look anymore like in the design. But it's better then a broken one. Let's merge it, but maybe we need to adjust it again. |
markus-moser
deleted the
1400-data-object-tree-unpublished-icon-is-cropped
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this pull request
Resolves #1400
Additional info
This pull request updates the styling of the
subIconcomponent in theicon.styles.tsfile to improve its positioning and layering. The key changes involve adjustments to thez-index, position, and dimensions of thesubIcon.Styling updates for
subIcon:z-indexto100to ensure thesubIconappears above other elements.left: -5pxandtop: 50%withbottom: 0andleft: 0, and removed the vertical centering transform (transform: translateY(-50%)).widthandheightof thesvginsidesubIconto inherit the dimensions of the parent element.