Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the desciption about cluster index and pre split region on auto random column #20551

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Fix the desciption about cluster index and pre split region on auto random column #20551

merged 1 commit into from
Mar 17, 2025

Conversation

YangKeao
Copy link
Member

@YangKeao YangKeao commented Mar 17, 2025 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Modify the limitation of cluster index. PRE_SPLIT_REGION is supported for auto random column.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 17, 2025
@YangKeao YangKeao mentioned this pull request Mar 17, 2025
Merged
16 tasks
@YangKeao YangKeao requested a review from tangenta March 17, 2025 09:33
@Oreoxmt Oreoxmt self-assigned this Mar 17, 2025
@Oreoxmt Oreoxmt added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. labels Mar 17, 2025
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Mar 17, 2025
@Oreoxmt Oreoxmt added type/bugfix This PR fixes a bug. ONCALL Relates to documentation oncall. labels Mar 17, 2025
Oreoxmt
Oreoxmt reviewed Mar 17, 2025
View reviewed changes
Oreoxmt
Oreoxmt approved these changes Mar 17, 2025
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 17, 2025
@YangKeao
fix the desciption about cluster index and pre split region on auto r…
ac3f64e 
…andom column

Signed-off-by: Yang Keao <yangkeao@chunibyo.icu>
@YangKeao YangKeao force-pushed the fix-auto-random-cluster-index-doc branch from d63be59 to ac3f64e Compare March 17, 2025 09:56
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 17, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 17, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-03-17 09:44:16.667978469 +0000 UTC m=+262350.352214565: ☑️ agreed by Oreoxmt.
  • 2025-03-17 09:58:10.622107782 +0000 UTC m=+263184.306343880: ☑️ agreed by tangenta.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Mar 17, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 17, 2025
@ti-chi-bot ti-chi-bot mentioned this pull request Mar 17, 2025
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #20555.

This was referenced Mar 17, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #20556.

This was referenced Mar 17, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #20557.

This was referenced Mar 17, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20558.

This was referenced Mar 17, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.4: #20559.

This was referenced Mar 17, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #20560.

This was referenced Mar 17, 2025
Merged
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.3: #20561.

@ti-chi-bot ti-chi-bot mentioned this pull request Mar 17, 2025
Merged
16 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Mar 17, 2025
@ti-chi-bot
Fix the desciption about cluster index and pre split region on auto r…
075ec7b 
…andom column (#20551) (#20561)
ti-chi-bot bot pushed a commit that referenced this pull request Mar 17, 2025
@ti-chi-bot
Fix the desciption about cluster index and pre split region on auto r…
e07965d 
…andom column (#20551) (#20560)
ti-chi-bot bot pushed a commit that referenced this pull request Mar 17, 2025
@ti-chi-bot
Fix the desciption about cluster index and pre split region on auto r…
ffa54b0 
…andom column (#20551) (#20559)
ti-chi-bot bot pushed a commit that referenced this pull request Mar 17, 2025
@ti-chi-bot
Fix the desciption about cluster index and pre split region on auto r…
b8cdcd0 
…andom column (#20551) (#20555)
ti-chi-bot bot pushed a commit that referenced this pull request Mar 17, 2025
@ti-chi-bot
Fix the desciption about cluster index and pre split region on auto r…
897a7d1 
…andom column (#20551) (#20558)
ti-chi-bot bot pushed a commit that referenced this pull request Mar 17, 2025
@ti-chi-bot
Fix the desciption about cluster index and pre split region on auto r…
90ecf20 
…andom column (#20551) (#20557)
ti-chi-bot bot pushed a commit that referenced this pull request Mar 17, 2025
@ti-chi-bot
Fix the desciption about cluster index and pre split region on auto r…
42d2f26 
…andom column (#20551) (#20554)
ti-chi-bot bot pushed a commit that referenced this pull request Mar 17, 2025
@ti-chi-bot
Fix the desciption about cluster index and pre split region on auto r…
479bc36 
…andom column (#20551) (#20553)
ti-chi-bot bot pushed a commit that referenced this pull request Mar 17, 2025
@ti-chi-bot
Fix the desciption about cluster index and pre split region on auto r…
9ecb5f7 
…andom column (#20551) (#20556)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved lgtm needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.3 Should cherry pick this PR to release-8.3 branch. needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YangKeao @Oreoxmt @ti-chi-bot @tangenta