Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8915] Migrate most of junit4 test to junit5 test #8975

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

donghun-cho
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #8975 (31b6500) into master (8c1e394) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8975      +/-   ##
============================================
- Coverage     39.76%   39.75%   -0.02%     
+ Complexity    11792    11790       -2     
============================================
  Files          3346     3346              
  Lines         90805    90805              
  Branches      10053    10053              
============================================
- Hits          36107    36096      -11     
- Misses        51608    51615       +7     
- Partials       3090     3094       +4     
Impacted Files Coverage Δ
...p/pinpoint/rpc/client/WriteFailFutureListener.java 56.25% <0.00%> (-25.00%) ⬇️
...vercorp/pinpoint/rpc/packet/ServerClosePacket.java 47.82% <0.00%> (-17.40%) ⬇️
...rp/pinpoint/rpc/server/PinpointServerAcceptor.java 84.10% <0.00%> (-4.64%) ⬇️
...tor/metric/datasource/DefaultDataSourceMetric.java 85.18% <0.00%> (-3.71%) ⬇️
...ollector/cluster/zookeeper/ZookeeperJobWorker.java 76.47% <0.00%> (-1.61%) ⬇️
...pinpoint/profiler/monitor/DeadlockMonitorTask.java 20.45% <0.00%> (-1.14%) ⬇️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 75.92% <0.00%> (+7.40%) ⬆️
...m/navercorp/pinpoint/rpc/client/ConnectFuture.java 79.16% <0.00%> (+8.33%) ⬆️
...npoint/metric/web/mybatis/DataSourceDelegator.java 21.42% <0.00%> (+21.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c1e394...31b6500. Read the comment docs.

@donghun-cho donghun-cho marked this pull request as draft June 24, 2022 10:11
@donghun-cho donghun-cho force-pushed the junit4to5 branch 3 times, most recently from 25f807d to 6f8b372 Compare June 29, 2022 05:15
@donghun-cho donghun-cho marked this pull request as ready for review June 29, 2022 05:48
@donghun-cho donghun-cho merged commit 8bd106e into pinpoint-apm:master Jul 1, 2022
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
@emeroad emeroad added the test label Dec 26, 2022
@donghun-cho donghun-cho deleted the junit4to5 branch August 31, 2023 05:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants