Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Guard NPE while processing phone number #9050

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

smilu97
Copy link
Contributor

@smilu97 smilu97 commented Jul 18, 2022

Adds null-checking before removing hyphen in phone number

@smilu97 smilu97 requested a review from minwoo-jung July 18, 2022 10:16
@codecov
Copy link

codecov bot commented Jul 18, 2022

Codecov Report

Merging #9050 (0a65ab7) into master (5e5e57a) will increase coverage by 0.00%.
The diff coverage is 71.42%.

@@            Coverage Diff            @@
##             master    #9050   +/-   ##
=========================================
  Coverage     39.78%   39.79%           
  Complexity    11828    11828           
=========================================
  Files          3365     3365           
  Lines         90937    90938    +1     
  Branches      10090    10090           
=========================================
+ Hits          36181    36187    +6     
+ Misses        51658    51654    -4     
+ Partials       3098     3097    -1     
Impacted Files Coverage Δ
...orp/pinpoint/web/service/UserGroupServiceImpl.java 39.70% <71.42%> (+3.88%) ⬆️
...p/pinpoint/rpc/client/WriteFailFutureListener.java 56.25% <0.00%> (-25.00%) ⬇️
...vercorp/pinpoint/rpc/packet/ClientClosePacket.java 46.66% <0.00%> (-6.67%) ⬇️
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 79.83% <0.00%> (-1.24%) ⬇️
...r/context/storage/AsyncQueueingUriStatStorage.java 85.29% <0.00%> (+16.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e5e57a...0a65ab7. Read the comment docs.

@smilu97 smilu97 force-pushed the #noissue_guard_npe_phonenumber branch from 94b1bbe to 0a65ab7 Compare July 21, 2022 02:39
@smilu97 smilu97 merged commit 73334de into pinpoint-apm:master Jul 21, 2022
@smilu97 smilu97 deleted the #noissue_guard_npe_phonenumber branch July 21, 2022 03:53
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants