Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#9666] Add redis pubsub atc,atc,echo #9767

Merged
merged 1 commit into from
May 17, 2023
Merged

[#9666] Add redis pubsub atc,atc,echo #9767

merged 1 commit into from
May 17, 2023

Conversation

smilu97
Copy link
Contributor

@smilu97 smilu97 commented Mar 10, 2023

No description provided.

@smilu97 smilu97 added this to the 2.6.0 milestone Mar 10, 2023
@smilu97 smilu97 self-assigned this Mar 10, 2023
@smilu97 smilu97 linked an issue Mar 10, 2023 that may be closed by this pull request
Replace fully connected connections between collector and web with Redis #9666
Closed
@codecov
Copy link

codecov bot commented Mar 10, 2023 •
edited
Loading

Codecov Report

Merging #9767 (2cd0526) into master (455c291) will decrease coverage by 0.02%.
The diff coverage is 33.01%.

❗ Current head 2cd0526 differs from pull request most recent head 8e1c8b3. Consider uploading reports for the commit 8e1c8b3 to get more accurate results

@@             Coverage Diff              @@
##             master    #9767      +/-   ##
============================================
- Coverage     38.79%   38.77%   -0.02%     
- Complexity    11871    12030     +159     
============================================
  Files          3536     3626      +90     
  Lines         93880    95434    +1554     
  Branches      10479    10537      +58     
============================================
+ Hits          36425    37009     +584     
- Misses        54292    55235     +943     
- Partials       3163     3190      +27
Impacted Files Coverage Δ
.../collector/grpc/config/GrpcReceiverProperties.java 91.30% <0.00%> (+23.56%) ⬆️
...nt/realtime/collector/RealtimeCollectorConfig.java 0.00% <0.00%> (ø)
...thread/count/CollectorActiveThreadCountConfig.java 0.00% <0.00%> (ø)
...ad/count/service/ActiveThreadCountServiceImpl.java 0.00% <0.00%> (ø)
...rvice/CollectorActiveThreadCountServiceConfig.java 0.00% <0.00%> (ø)
...vethread/dump/CollectorActiveThreadDumpConfig.java 0.00% <0.00%> (ø)
...ervice/CollectorActiveThreadDumpServiceConfig.java 0.00% <0.00%> (ø)
...t/realtime/collector/echo/CollectorEchoConfig.java 0.00% <0.00%> (ø)
...ector/echo/service/CollectorEchoServiceConfig.java 0.00% <0.00%> (ø)
...altime/collector/echo/service/EchoServiceImpl.java 0.00% <0.00%> (ø)
... and 86 more

... and 109 files with indirect coverage changes

@smilu97 smilu97 changed the title [#9666] Alternative realtime communication through Redis [#9666] Add redis pubsub Mar 27, 2023
@smilu97 smilu97 marked this pull request as ready for review March 27, 2023 08:33
@smilu97 smilu97 force-pushed the 9666_redis branch 2 times, most recently from bb079eb to 4939cdb Compare March 30, 2023 10:14
@smilu97 smilu97 changed the title [#9666] Add redis pubsub [#9666] Add redis pubsub atc,atc,echo Mar 30, 2023
@smilu97 smilu97 force-pushed the 9666_redis branch 2 times, most recently from e6b8dd8 to e059ae5 Compare March 31, 2023 05:33
@smilu97 smilu97 force-pushed the 9666_redis branch 2 times, most recently from 9cef2af to 2cd0526 Compare April 18, 2023 02:09
@smilu97 smilu97 merged commit 482ec0b into pinpoint-apm:master May 17, 2023
@smilu97 smilu97 deleted the 9666_redis branch May 17, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smilu97 smilu97

Labels
module:collector module:web
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Replace fully connected connections between collector and web with Redis
1 participant
@smilu97