Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Computed height does not include padding #14

Closed
edmelly opened this issue Nov 28, 2014 · 1 comment
Closed

Computed height does not include padding #14

edmelly opened this issue Nov 28, 2014 · 1 comment

Comments

@edmelly
Copy link

edmelly commented Nov 28, 2014

If your target container has top/bottom padding, then the computed height of its parallax element will be too short (not taking padding into account). Changing line 167 to use outerHeight instead of height fixed the issue for me.
mikegreiling added a commit that referenced this issue Dec 5, 2014
@mikegreiling
close issue #14
601068c
@mikegreiling
Copy link
Member

fixed for 1.2.1, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikegreiling @edmelly