Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KawaseBlurFilter #114

Merged
merged 12 commits into from
Jan 9, 2018
Merged

Add KawaseBlurFilter #114

merged 12 commits into from
Jan 9, 2018

Conversation

finscn
Copy link
Contributor

@finscn finscn commented Dec 18, 2017

It's a more faster blur algorithm than Gaussian Blur.

more details at : https://software.intel.com/en-us/blogs/2014/07/15/an-investigation-of-fast-real-time-gpu-based-image-blur-algorithms

P.S. : @bigtimebuddy , I don't add any document about it , because it's too hard to me in this filter...
And I think this filter is not for junior user , if an user wants to use it well , he/she needs to understand the algorithm.

After this PR be merged , I will update AdvancedBloomFilter , make it support KawaseBlurFilter

@finscn
Copy link
Contributor Author

finscn commented Dec 18, 2017

About performance , you could see this : http://finscn.github.com/pixi-filters/index.html

try <fish> Blur filter (pixi.js) & <fish> KawaseBlur filter , you will see KawaseBlur is faster.
And in some cases , it's more than 4x faster , and in some cases it's less than 2x.
But whatever , it's always faster.

@bigtimebuddy bigtimebuddy added this to the v2.5.0 milestone Dec 24, 2017
@bigtimebuddy
Copy link
Member

@finscn I like this filter and the performance benefits but it's very difficult to use. Can you suggest anyways we might improve to make it more usable?

@finscn
Copy link
Contributor Author

finscn commented Jan 9, 2018

I have an idea.
Give me some times.

@finscn
Copy link
Contributor Author

finscn commented Jan 9, 2018

@bigtimebuddy , Done.
Please review & refactor it , make it better , thanks.

Now, it could generate kernels by blur & quality.

And for Advanced Users , they still could custom kernels by themselves.

Copy link
Member

@bigtimebuddy bigtimebuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better!

@bigtimebuddy bigtimebuddy merged commit ff2746e into pixijs:master Jan 9, 2018
@finscn finscn deleted the filter-kawase-blur branch January 15, 2018 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants