Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for velocity being an ObservablePoint #162

Merged
merged 1 commit into from
May 3, 2018
Merged

Adds support for velocity being an ObservablePoint #162

merged 1 commit into from
May 3, 2018

Conversation

bigtimebuddy
Copy link
Member

@bigtimebuddy bigtimebuddy commented May 3, 2018 •
edited
Loading

Fixes #161

Changed

  • MotionBlur's velocity property is now a PIXI.ObservablePoint so that changes automatically update the uniforms without needing to resetting velocity

@bigtimebuddy bigtimebuddy merged commit e7fa532 into master May 3, 2018
@bigtimebuddy bigtimebuddy deleted the motion-blur-velocity branch May 3, 2018 14:13
@finscn
Copy link
Contributor

finscn commented May 3, 2018

the performance of ObservablePoint is bad :(

@ivanpopelyshev
Copy link
Contributor

ivanpopelyshev commented May 3, 2018 •
edited
Loading

Do you change this thing often on a filter? Each filter is worse than 10000 observables

@finscn
Copy link
Contributor

finscn commented May 5, 2018

In my game, I will change it every game tick, except characters don't move.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanpopelyshev ivanpopelyshev ivanpopelyshev approved these changes

Assignees

@ivanpopelyshev ivanpopelyshev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bigtimebuddy @finscn @ivanpopelyshev