This repository was archived by the owner on Aug 20, 2024. It is now read-only.
fix: make it compatible with playwright-test #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
force-pushed
the
compatible-with-playwright-test
branch
from
ed930da to
3132d7d
Compare
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
=======================================
Coverage 90.97% 90.97%
=======================================
Files 10 10
Lines 144 144
Branches 26 26
=======================================
Hits 131 131
Misses 13 13 Continue to review full report at Codecov.
|
mskelton
reviewed
Jun 8, 2021
mxschmitt
force-pushed
the
compatible-with-playwright-test
branch
from
4a0c829 to
4cc3665
Compare
mskelton
approved these changes
Jun 8, 2021
README.md
Outdated
| ```js | ||
| // foo.spec.ts | ||
| import { test, expect } from "@playwright/test" | ||
| import "expect-playwright" |
There was a problem hiding this comment.
Wondering if we need this section given the TypeScript section at the bottom of the readme:
https://github.com/playwright-community/expect-playwright#typescript
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets released soon: https://playwright.dev/docs/next/test-intro/
I tested it locally, seems to work.