Skip to content

Stop Time Zone changes #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gasman32 opened this issue Sep 22, 2015 · 15 comments
Closed

Stop Time Zone changes #201

gasman32 opened this issue Sep 22, 2015 · 15 comments
Milestone

Comments

@gasman32
Copy link

Could you add a feature like android calendar has to keep event times from changing when travelling to different time zones. It's frustrating when the times change in the widget because they were made in a different time zone. My full calendar keeps the times at the original ones so I have 2 times for each calendar event: the widget and the full calendar.
Thanks

@yvolk
Copy link
Collaborator

yvolk commented Sep 25, 2015

This enhancement will have an additional benefit: it will allow to automate testing using different time zones. See #190

@yvolk
Copy link
Collaborator

yvolk commented Oct 3, 2015

I think that interface of this setting may be very simple: just a checkbox.
Title : Fix current time zone
Summary:

  1. When off: Timezone name, not fixed.
  2. When on: Fixed: Timezone name.
    Actual "fix" occurs when a User sets this checkbox.

@mpost
Copy link
Collaborator

mpost commented Oct 3, 2015

The naming "fix" is very ambiguous. It should describe what is actually happening.

Eg.: "Adjust times to local timezone" with default being "on" (current behavior).

@jkufner
Copy link

jkufner commented Oct 3, 2015

It is not really "adjusting" nor "fixing". The time of an event is not changed in any way. Only the way how it is displayed is changed.

When a time of an event is not displayed in current (local) time zone, the timezone must be displayed together with the time. Otherwise it shows wrong data.

When traveling by plane, I often have flight represented as an event which has begins in one time zone and ends in another. Lightning (calendar extension for Thunderbird) shows both times in local time zones when event is displayed in calendar view, but when event is edited, each time is shown in time zone specified by user (so the same numbers are on flight ticket and in calendar).

@yvolk
Copy link
Collaborator

yvolk commented Oct 4, 2015

@mpost @jkufner Maybe a word "Lock" is better.
So the title of the checkbox would be: "Lock current Time Zone" ?!
Actually, by "Lock Time Zone" I found the "Time Zone Lock" feature of the Jorte Calendar - this is very close to what we are talking about. But what we do is simpler, since we don't need a list of Time Zones to select from - we Lock at current Time Zone.

@yvolk yvolk changed the title Feature Request: Stop Time Zone changes Stop Time Zone changes Oct 4, 2015
@gasman32
Copy link
Author

gasman32 commented Oct 4, 2015

My calendar program has a box in set up that is labeled "use home time
zone" with an explanation.
On Oct 3, 2015 4:28 PM, "Josef Kufner" notifications@github.com wrote:

It is not really "adjusting" nor "fixing". The time of an event is not
changed in any way. Only the way how it is displayed is changed.

When a time of an event is not displayed in current (local) time zone, the
timezone must be displayed together with the time. Otherwise it shows wrong
data.

When traveling by plane, I often have flight represented as an event which
has begins in one time zone and ends in another. Lightning (calendar
extension for Thunderbird) shows both times in local time zones when event
is displayed in calendar view, but when event is edited, each time is shown
in time zone specified by user (so the same numbers are on flight ticket
and in calendar).


Reply to this email directly or view it on GitHub
#201 (comment)
.

@yvolk
Copy link
Collaborator

yvolk commented Oct 8, 2015

The "Time Zone Lock" feature tested to work as expected internally: it is now a part of a test suite, used when we need to replay a list of events in a specific time zone.

@gasman32
Copy link
Author

gasman32 commented Oct 8, 2015

Great!
On Oct 8, 2015 12:39 AM, "Yuri Volkov" notifications@github.com wrote:

The "Time Zone Lock" feature tested to work as expected internally: it is
now a part of a test suite, used when we need to replay a list of events in
a specific time zone.


Reply to this email directly or view it on GitHub
#201 (comment)
.

@yvolk
Copy link
Collaborator

yvolk commented Oct 9, 2015

So I propose this implementation of the feature: just a checkbox.
Title : Time Zone Lock
Summary:

  1. When off: Unlocked, current zone: Timezone name
  2. When on: Locked at Timezone name.
    Actual "lock" occurs when a User sets this checkbox.
    ?!

@gasman32
Copy link
Author

gasman32 commented Oct 9, 2015

Perfect! Thanks.
On Oct 9, 2015 1:11 AM, "Yuri Volkov" notifications@github.com wrote:

So I propose this implementation of the feature: just a checkbox.
Title : Time Zone Lock
Summary:

  1. When off: Unlocked, current zone: Timezone name
  2. When on: Locked at Timezone name.
    Actual "lock" occurs when a User sets this checkbox.
    ?!


Reply to this email directly or view it on GitHub
#201 (comment)
.

@mpost
Copy link
Collaborator

mpost commented Oct 9, 2015

I like the short wording. How about we streamline it a little to be more in synch with the other settings? Eg "lock timezone".

@yvolk
Copy link
Collaborator

yvolk commented Oct 9, 2015

@mpost good: "Lock time zone" ("time zone" is used in Android settings. We need to be consistent )

@mpost
Copy link
Collaborator

mpost commented Oct 9, 2015

@yvolk yeah agreed. "time zone" is correct.

@yvolk
Copy link
Collaborator

yvolk commented Mar 26, 2017

Implemented

@yvolk
Copy link
Collaborator

yvolk commented Apr 2, 2017

To be released in v.1.10.0

@yvolk yvolk closed this as completed Apr 2, 2017
@yvolk yvolk mentioned this issue Nov 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants