Tasks fixes #312
Merged
Tasks fixes #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvolk
requested changes
Jul 18, 2019
| @@ -32,6 +35,19 @@ public int getDaysFromToday() { | |||
| startDate.withTimeAtStartOfDay()).getDays(); | |||
| } | |||
|
|
|||
| public CharSequence getDaysFromTodayString(Context context, int daysFromToday) { | |||
There was a problem hiding this comment.
Moving the formatting method (which is about presentation) to the data class is incorrect.
| protected DateTime getDueDate(Long dueMillis) { | ||
| if (dueMillis == null) { | ||
| return now.withTimeAtStartOfDay(); | ||
| protected DateTime getDueDate(Long dueMillis, Long startMillis) { |
There was a problem hiding this comment.
"getDueDate" should return due date. Logic of choosing, which date to take for showing in the widget, should be clear and explicit and definitely shouldn't be called "getDueDate".
If there is a due date, the start date is ignored. But if there is no due date but there is a start date, the start date is used as the task's date.
|
Everything should be fixed now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the layout for tasks for "All in one line", and supports start dates.