bugfix/issue-143 #144
Merged
bugfix/issue-143 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frankinspace
approved these changes
Feb 13, 2023
danielfromearth
deleted the
feature/issue-143-no-variables-with-groups-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: #143
Description
Fix a
TypeErrorthat's raised when no variables are specified for a netCDF file that has groups.Overview of work done
Added a check for
Nonebefore modifying the variable paths.Overview of verification done
Verified that the suite of automated tests all passed successfully.
Overview of integration done
No integration testing was done.
PR checklist:
[N/A] Updated unit tests
See Pull Request Review Checklist for pointers on reviewing this pull request