Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 209 #214

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Feature/issue 209 #214

merged 5 commits into from
Nov 21, 2023

Conversation

sliu008
Copy link
Contributor

@sliu008 sliu008 commented Nov 21, 2023

Github Issue: #209

Description

  • SWOT_L2_NALT_IGDR_SGDR_1.0 failing l2ss-py in UAT and OPS

Overview of work done

  • Update dimension creation to only when the dimension doesn't already exists
  • Update code on how we update a shapefile from 180 to 360 lon lats.

Overview of verification done

  • tested locally on SWOT_L2_NALT_IGDR_SGDR_1.0

Overview of integration done

  • tested on local harmony

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@sliu008 sliu008 requested a review from jamesfwood November 21, 2023 17:32
@sliu008 sliu008 merged commit bd02328 into develop Nov 21, 2023
@sliu008 sliu008 deleted the feature/issue-209 branch November 21, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesfwood jamesfwood jamesfwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sliu008 @jamesfwood