Feature/issue-205 #215
Merged
Feature/issue-205 #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Synk seems to be failing, and I'm not sure how to trouble shoot that |
|
@nlenssen2013 there are some conflicts that need fixing. Also, don't worry about the Synk and SonarCloud failure. I have another branch to address that. But if you can fix the conflicts then we should be able to merge this. |
Conflicts are fixed. Added a small issue fix with the compute time coordinates function. Let me know if it's acceptable. |
jamesfwood
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: #205 , #220
Description
If there are dimensions that have the same string name but different values in different groups. Then the xarray.rename_dims function will need to be used so that the copying variables back into the netCDF dataset is successfull
Overview of work done
get the names of dimensions that have different values and then put the old name and new name into the .rename_dims for an updated dataset. Check that the same time variable isn't added
Overview of verification done
run bounding box test on OMIPIXCOR data file
Overview of integration done
Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request