Fix an issue where % was getting double encoded in query params #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VShingala
approved these changes
Apr 18, 2023
dhwaneetbhatt
force-pushed
the
bug/fix-double-encoding-for-percent
branch
4 times, most recently
from
0315022 to
d00b39d
Compare
dhwaneetbhatt
force-pushed
the
bug/fix-double-encoding-for-percent
branch
from
d00b39d to
c076f20
Compare
VShingala
reviewed
Apr 19, 2023
| .replace(/%5D/g, ']') | ||
| .replace(/%7D/g, '}') | ||
| .replace(/%25/g, '%') |
There was a problem hiding this comment.
@dhwaneetbhatt Any reason to not encode { and } here anymore?
There was a problem hiding this comment.
@VShingala In Java-unirest library, using characters { and } resulted in IllegalURLException being thrown by the library. We caught this now only because we added a Newman test. So we cannot have those characters in the URL. This is not a problem with other Java libraries (OkHttp) so seems like a bug with unirest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #638, we moved the encoding to the modules, which led to double encoding.
The fix would be to remove double encoding and make this fix in all other modules as well which are now doing double encoding of
%.