Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show session verification box for turbo requests #11954

Merged
merged 4 commits into from
Mar 5, 2025

Conversation

nanaya
Copy link
Collaborator

@nanaya nanaya commented Feb 28, 2025

Also changed how turbo redirect works.

Also changed how turbo redirect works.
Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if going to somewhere directly like community/chat#join with an account or env required to verify on login, it just spins instead of showing the verification

@nanaya
Copy link
Collaborator Author

nanaya commented Mar 4, 2025

if going to somewhere directly like community/chat#join with an account or env required to verify on login, it just spins instead of showing the verification

what's exactly the steps and env?

(all I got is things explode internally and turbo ended up doing browser visit instead - also fixed)

@nanaya nanaya force-pushed the turbo-error-handling branch from 7810ba8 to 3ef1382 Compare March 4, 2025 03:27
@nanaya nanaya force-pushed the turbo-error-handling branch 2 times, most recently from 69c1a4d to 2cb0376 Compare March 4, 2025 03:34
@notbakaneko
Copy link
Collaborator

I just went directly to /community/chat#join and logged in as an admin 🤔

@nanaya
Copy link
Collaborator Author

nanaya commented Mar 4, 2025

is it still a problem? I can't seem to reproduce it.

Copy link
Collaborator

@notbakaneko notbakaneko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working now

@notbakaneko notbakaneko enabled auto-merge March 5, 2025 09:18
@notbakaneko notbakaneko merged commit 5e71d23 into ppy:master Mar 5, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants